On Fri, 2022-08-26 at 08:48 -0700, Jeff Johnson wrote:
>
> > @@ -3268,6 +3270,7 @@ enum nl80211_attrs {
> >
> > NL80211_ATTR_TX_HW_TIMESTAMP,
> > NL80211_ATTR_RX_HW_TIMESTAMP,
> > + NL80211_ATTR_TD_BITMAP,
> >
> > /* add attributes here, update the policy in nl80211.c */
>
> Johannes, do you want the policy updated even thought this is
> driver->userspace and hence the policy is never applied to it?
Yeah in a sense, it doesn't really matter... I think not updating is
fine, then it will likely even be rejected, at least in any new
commands.
> > struct {
> > u8 bssid[ETH_ALEN];
> > + s16 td_bitmap;
>
> I know you are using -1 as an indication that the bitmap is not used,
> but using signed with a bitmap seems strange since bitops can be
> affected by sign extension. Just something that set off my Spider-Sense.
Yeah true ... maybe a separate validity bool would've been better?
dunno.
johannes
