On Thu, Oct 23, 2008 at 9:52 AM, Sujith <m.sujith@xxxxxxxxx> wrote: > John W. Linville wrote: >> > Poke. >> >> Just waiting to see comments from those who understand aggregation >> better than I do... > > It doesn't change the existing behaviour in any way, ath9k doesn't need > all the extra queue stuff, so this is only a temporary fix until > we have a decent model in mac80211 to support HW with > no ampdu_queues. Just to give some perspective, the reason this has been painful is we are dealing with the two most distinct type of wireless devices you could get and we deal with aggregation in different ways. Aggregation is also very new to mac80211 but its implementation was designed specifically for cases where you have "amdpu queues". Our design requires everything done in software and as such the real clean solution is to eventually try to move *as much as is possible* to mac80211 to allow other devices which behave the same to be able to use the same aggregation code. For now though for the non amdpu queue case we only have Atheros 11n though and we are trying to resolve that case first. We will commit to move as much stuff up as we can, and this will become more important as we get another device supported using the same design. I've been trying hard to review and ask about the design details of the other devices out in the market. In any case I think this is the right step forward in the meantime, I also made a suggestion as to how the ampdu queue case might be resolved. We just need to be sure we keep in mind what needs to be done and move towards it. That's my two colones. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
