On Thu, 2022-08-11 at 23:46 -0700, Muna Sinada wrote: > > + * @vht_su_beamformer: does this BSS support operation as an VHT SU beamformer > + * @vht_su_beamformee: does this BSS support operation as an VHT SU beamformee > + * @vht_mu_beamformer: does this BSS support operation as an VHT MU beamformer > + * @vht_mu_beamformee: does this BSS support operation as an VHT MU beamformee Should probably say that you meant this only for AP mode? Though why not fill it also in client mode? > link_conf->beacon_int = params->beacon_interval; You rebased on a multi-link tree ... > + if (params->vht_cap) { > + sdata->vif.bss_conf.vht_su_beamformer = but still used vif.bss_conf :) Please respin with MLO support. johannes