Search Linux Wireless

Re: [PATCH 3/3] wifi: rtw89: correct BA CAM allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ping-Ke,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v6.0-rc1 next-20220815]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ping-Ke-Shih/wifi-rtw89-correct-BA-CAM-allocation/20220815-151009
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20220815/202208152030.442QsT2L-lkp@xxxxxxxxx/config)
compiler: hppa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/336a217f279e1188ec626d83a9f6edc636e68aa5
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ping-Ke-Shih/wifi-rtw89-correct-BA-CAM-allocation/20220815-151009
        git checkout 336a217f279e1188ec626d83a9f6edc636e68aa5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/realtek/rtw89/debug.c: In function 'rtw89_dump_ba_cam':
>> drivers/net/wireless/realtek/rtw89/debug.c:2450:42: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'int' [-Wformat=]
    2450 |                 seq_printf(m, "tid[%u]=%ld", entry->tid,
         |                                        ~~^
         |                                          |
         |                                          long int
         |                                        %d
    2451 |                            entry - rtwdev->cam_info.ba_cam_entry);
         |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                                  |
         |                                  int


vim +2450 drivers/net/wireless/realtek/rtw89/debug.c

  2435	
  2436	static void rtw89_dump_ba_cam(struct seq_file *m, struct rtw89_sta *rtwsta)
  2437	{
  2438		struct rtw89_vif *rtwvif = rtwsta->rtwvif;
  2439		struct rtw89_dev *rtwdev = rtwvif->rtwdev;
  2440		struct rtw89_ba_cam_entry *entry;
  2441		bool first = true;
  2442	
  2443		list_for_each_entry(entry, &rtwsta->ba_cam_list, list) {
  2444			if (first) {
  2445				seq_puts(m, "\tba_cam ");
  2446				first = false;
  2447			} else {
  2448				seq_puts(m, ", ");
  2449			}
> 2450			seq_printf(m, "tid[%u]=%ld", entry->tid,
  2451				   entry - rtwdev->cam_info.ba_cam_entry);
  2452		}
  2453		seq_puts(m, "\n");
  2454	}
  2455	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux