Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > Since IQK could spend time, we make a cache of IQK result matrix that looks > like iqk_matrix[channel_idx].val[x][y], and we can reload the matrix if we > have made a cache. To determine a cache is made, we check > iqk_matrix[channel_idx].val[0][0]. > > The initial commit 7274a8c22980 ("rtlwifi: rtl8192de: Merge phy routines") > make a mistake that checks incorrect iqk_matrix[channel_idx].val[0] that > is always true, and this mistake is found by commit ee3db469dd31 > ("wifi: rtlwifi: remove always-true condition pointed out by GCC 12"), so > I recall the vendor driver to find fix and apply the correctness. > > Fixes: 7274a8c22980 ("rtlwifi: rtl8192de: Merge phy routines") > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. 93fbc1ebd978 wifi: rtlwifi: 8192de: correct checking of IQK reload -- https://patchwork.kernel.org/project/linux-wireless/patch/20220801113345.42016-1-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches