On Wed, Oct 22, 2008 at 12:31:09PM -0700, Johannes Berg wrote: > On Wed, 2008-10-22 at 05:29 -0700, Luis R. Rodriguez wrote: > > On Wed, Oct 22, 2008 at 11:51:36AM -0700, Johannes Berg wrote: > > > -/* wiphy is set if this request's initiator is REGDOM_SET_BY_DRIVER */ > > > +/* wiphy is set if this request's initiator is REGDOM_SET_BY_COUNTRY_IE */ > > > > Why don't we want to keep track of the wiphy if the driver set it? > > Why would we? I removed it from the hinting functions so that we don't > need to have a valid wiphy to call a hint, which seems quite possible? Well, the alpha2 hint from country IE we'd built it from the IE and then try call an rd hint routine, I take it now it would be the new struct one. OK -- in that one we have the wiphy. In that case that routine needs to be updated to check to see if the initiator is country IE and if so mark XXX do to intersection. Then the reason I kept the wiphy around for the regular alpha2 case is you will want to keep track if a different wiphy sent this new alpha2 request. If so I think we do interesection then, or let the user disable one or something. But yea its useful to keep track of I think. I thought you didn't remove it from ignore_request(), hm.. that's where we use it to do all these checks. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
