On 7/28/2022 11:39 AM, Kalle Valo wrote:
aspriel@xxxxxxxxx writes:
Instead of using EXPORT_SYMBOL() use namespace variant and only if
build vendor-specific code as separate module.
The commit log should always answer to the question "why?".
Let me try:
Exported symbols are usable from any kernel module. Using the namespace
variant requires the caller to explicitly import the symbols. This makes
it more clear that these are only intended to be used by brcmfmac
driver. When vendor-support is built-in there is no reason to export the
symbols at all.
If the above is acceptable I will use that when resending the patch series.
Regards,
Arend