aspriel@xxxxxxxxx writes: > The driver is being used by multiple vendors who develop the firmware > api independently. So far the firmware api as used by the driver has > not diverged (yet). This change adds framework for supporting multiple > firmware apis. The vendor-specific support code has to provide a number > of callback operations. Right now it is only attach and detach callbacks > so no real functionality as the api is still common. This code only > adds WCC variant anyway, which is selected for all devices right now. > > Reviewed-by: Hante Meuleman <hante.meuleman@xxxxxxxxxxxx> > Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@xxxxxxxxxxxx> > Reviewed-by: Franky Lin <franky.lin@xxxxxxxxxxxx> > Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> [...] > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/Kconfig > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/Kconfig > @@ -8,6 +8,22 @@ config BRCMFMAC > interface support. If you choose to build a module, it'll be called > brcmfmac.ko. > > +config BRCMFMAC_VENDOR_MODULES > + bool "Use vendor-specific modules" > + depends on BRCMFMAC = m > + help > + This option will build separate modules for the vendor-specific > + firmware support. If not selected the vendor-specific support > + will be build in brcmfmac.ko. > + > +config BRCMFMAC_VENDOR_WCC > + bool "Broadcom WCC" > + default y > + depends on BRCMFMAC > + help > + This option will allow the driver to communicate with devices > + shipped by Broadcom WCC division. > + I'm not really a fan of these Kconfig options, I would rather have them always enabled. Why do we need these options, what would be the use case when user disables these? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
