Rustam Subkhankulov <subkhankulov@xxxxxxxxx> wrote: > The assignment of the value to the variable total in the loop > condition must be enclosed in additional parentheses, since otherwise, > in accordance with the precedence of the operators, the conjunction > will be performed first, and only then the assignment. > > Due to this error, a warning later in the function after the loop may > not occur in the situation when it should. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Rustam Subkhankulov <subkhankulov@xxxxxxxxx> > Fixes: 0d4171e2153b ("p54: implement flush callback") > Acked-by: Christian Lamparter <chunkeey@xxxxxxxxx> Patch applied to wireless-next.git, thanks. bcfd9d7f6840 wifi: p54: add missing parentheses in p54_flush() -- https://patchwork.kernel.org/project/linux-wireless/patch/20220714134831.106004-1-subkhankulov@xxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches