Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote: > If an error occurs after a successful call to p54spi_request_firmware(), it > must be undone by a corresponding release_firmware() as already done in > the error handling path of p54spi_request_firmware() and in the .remove() > function. > > Add the missing call in the error handling path and remove it from > p54spi_request_firmware() now that it is the responsibility of the caller > to release the firmware > > Fixes: cd8d3d321285 ("p54spi: p54spi driver") > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > Acked-by: Christian Lamparter <chunkeey@xxxxxxxxx> Patch applied to wireless-next.git, thanks. 83781f0162d0 wifi: p54: Fix an error handling path in p54spi_probe() -- https://patchwork.kernel.org/project/linux-wireless/patch/297d2547ff2ee627731662abceeab9dbdaf23231.1655068321.git.christophe.jaillet@xxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches