Manikanta Pubbisetty <quic_mpubbise@xxxxxxxxxxx> writes: >> I refactored ath11k_pci_get_window_start() a bit, please check my >> changes here: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=95094045d7f467aa8928307ea538d1fd9d15a239 >> > > Refactored code looks okay to me. Just one comment though, you may > probably remove initialization of "u32 window_start = > ATH11K_PCI_WINDOW_START;" in ath11k_pci_window_read32? It is removed > in ath11k_pci_window_write32. Good point, removed that now: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=70fbceb8841910a2af9a392a6b1f4eb53c3a6716 -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
