On Mon, 27 Jun 2022 at 12:27, Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Robert Marko <robimarko@xxxxxxxxx> writes: > > > bus + qmi-chip-id + qmi-board-id and optionally the variant are currently > > used for identifying the correct board data file. > > > > This however is sometimes not enough as all of the IPQ8074 boards that I > > have access to dont have the qmi-board-id properly fused and simply return > > the default value of 0xFF. > > > > So, to provide the correct qmi-board-id add a new DT property that allows > > the qmi-board-id to be overridden from DTS in cases where its not set. > > This is what vendors have been doing in the stock firmwares that were > > shipped on boards I have. > > What's wrong with using 0xff? Ie. something like this: > > bus=ahb,qmi-chip-id=0,qmi-board-id=255,variant=foo > > Or maybe even just skip qmi-board-id entirely if it's not supported? So > that the board file string would be something like: > > bus=ahb,qmi-chip-id=0,variant=foo > > I really would like to avoid adding more DT properties unless it's > absolutely critical. Well, I suppose that due to the variant property we can avoid "correcting" the qmi-board-id Regards, Robert > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
