On 6/24/2022 11:32 AM, Paul Cercueil wrote:
Hi,
Le ven., juin 24 2022 at 09:31:22 -0700, Jeff Johnson
<quic_jjohnson@xxxxxxxxxxx> a écrit :
On 6/24/2022 2:24 AM, Arend Van Spriel wrote:
On 6/23/2022 2:42 PM, Paul Cercueil wrote:
[snip]
- if (sdiodev->freezer) {
+ if (IS_ENABLED(CONFIG_PM_SLEEP) && sdiodev->freezer) {
This change is not necessary. sdiodev->freezer will be NULL when
CONFIG_PM_SLEEP is not enabled.
but won't the compiler be able to completely optimize the code away if
the change is present?
That's correct. But do we want to complexify a bit the code for the sake
of saving a few bytes? I leave that as an open question to the
maintainer, I'm really fine with both options.
I'm fine either way as well. I'd have stronger opinions if ath drivers
were involved ;)
