Hello Johannes Berg,
This is a semi-automatic email about new static checker warnings.
The patch d648c23024bd: "wifi: nl80211: support MLO in auth/assoc"
from May 31, 2022, leads to the following Smatch complaint:
net/wireless/mlme.c:328 cfg80211_mlme_assoc()
warn: variable dereferenced before check 'req->bss' (see line 324)
net/wireless/mlme.c
323
324 err = rdev_assoc(rdev, dev, req);
^^^
req->bss dereferenced inside the function call
325 if (!err) {
326 int link_id;
327
328 if (req->bss) {
^^^^^^^^
Check for NULL is too late
329 cfg80211_ref_bss(&rdev->wiphy, req->bss);
330 cfg80211_hold_bss(bss_from_pub(req->bss));
regards,
dan carpenter
