Hi Felix, On Fri, 2022-06-17 at 10:39 +0200, Felix Fietkau wrote: > On 16.06.22 17:57, Deren Wu wrote: > > From: Deren Wu <deren.wu@xxxxxxxxxxxx> > > > > mt7921/mt7922 support HE max aggregation subframes 256 for both > > tx/rx. > > Get better throughput then before. > > > > Fixes: 94bb18b03d43 ("mt76: mt7921: fix max aggregation subframes > > setting") > > Tested-by: Ming Yen Hsieh <mingyen.hsieh@xxxxxxxxxxxx> > > Reviewed-by: Sean Wang <sean.wang@xxxxxxxxxxxx> > > Signed-off-by: Deren Wu <deren.wu@xxxxxxxxxxxx> > > When I made the change that you're reverting here, I used the values > from the reference SDK that I got, and the change actually seemed to > improve performance in my tests. > Did something change in the firmware, or is there a related chipset > difference between 7921 and 7922? > > - Felix > Yes, there was some fw changes ready in 2021 and the SDK was updated as well. After some performance re-check, the test result is much better with the new patch. We think the max-size-256 can be applied in mt7921/mt7922 driver now. PS: mt7921/mt7922 are the same. Both of them can support this size. Thanks, Deren