> -----Original Message----- > From: Larry Finger <larry.finger@xxxxxxxxx> On Behalf Of Larry Finger > Sent: Wednesday, June 8, 2022 9:03 AM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Nathan Chancellor <nathan@xxxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxx>; Johannes Berg <johannes@xxxxxxxxxxxxxxxx>; > linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 4/4] rtw88: Fix Sparse warning for rtw8821c_hw_spec > > On 6/7/22 19:25, Ping-Ke Shih wrote: > > > > > > Hi Larry, > > > > How about keeping rtw8821c_hw_spec const, but move ch_param[3] from > > 'struct rtw_chip_info' to 'struct rtw_hal'? > > > > If you agree this, I can prepare a patch. > > > > If that fixes the crashes, that is fine with me. The other 3 devices will need > the same fix. > The ch_param[3] is only used by 8821c, so it doesn't affect other devices. I will prepare a patch to fix it. Ping-Ke
