Manikanta Pubbisetty <quic_mpubbise@xxxxxxxxxxx> wrote: > Currently ar->ht_cap_info is not set anywhere in the code, this could > result in LDPC config computed wrongly in the set_bitrate_mask() hook > and eventually sending wrong config to the target. Fix this by checking > the LDPC support from the band HT capabilities of the radio instead. > > Furthermore, it looks like firmwares running on the ath11k hardware > do not set WMI_HT_CAP_LDPC for advertising the TX LDPC capability, > WMI_HT_CAP_TX_LDPC is set instead and this should be checked for > getting hardware's TX LDPC support. This is true for QCA6390, WCN6855 > & WCN6750 hardware. > > Also, remove unused variables ht_cap_info & vht_cap_info from > struct ath11k{}. > > Found this during code review. > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1 > > Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 4c1fc4f60a53 ath11k: Fix LDPC config in set_bitrate_mask hook -- https://patchwork.kernel.org/project/linux-wireless/patch/20220602124142.29909-1-quic_mpubbise@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches