> -----Original Message----- > From: Kalle Valo <kvalo@xxxxxxxxxx> > Sent: Friday, June 3, 2022 12:21 > To: Aditya Kumar Singh (QUIC) <quic_adisi@xxxxxxxxxxx> > Cc: ath11k@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Aditya > Kumar Singh (QUIC) <quic_adisi@xxxxxxxxxxx> > Subject: Re: [PATCH 1/2] ath11k: move firmware stats out of debugfs > > Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx> wrote: > > > Currently, firmware stats, comprising pdev, vdev and beacon stats are > > part of debugfs. In firmware pdev stats, firmware reports the final Tx > > power used to transmit each packet. If driver wants to know the final > > Tx power being used at firmware level, it can leverage from firmware > > pdev stats. > > > > Move firmware stats out of debugfs context in order to leverage the > > final Tx power reported in it even when debugfs is disabled. > > > > Tested-on: IPQ8074 hw2.0 AHB > > WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 > > Tested-on: QCN9074 hw1.0 PCI > > WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 > > Tested-on: WCN6855 hw2.0 PCI > > WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > > > Signed-off-by: Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx> > > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> > > This added new warnings: > > drivers/net/wireless/ath/ath11k/debugfs.c:94: Please don't use multiple > blank lines > drivers/net/wireless/ath/ath11k/debugfs.c:976: Blank lines aren't necessary > before a close brace '}' > I have sent [v2] before your mail. But that too will lead to these warnings hence I have rectified and sent [v3]. > I fixed them in the pending branch. Sure thanks. > > -- > https://patchwork.kernel.org/project/linux- > wireless/patch/20220602051425.9265-2-quic_adisi@xxxxxxxxxxx/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingp > atches
