On Wed, 2022-06-01 at 12:31 -0700, Jeff Johnson wrote: > On 6/1/2022 12:39 AM, Johannes Berg wrote: > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > Split the bss_info_changed method to vif_cfg_changed and > > link_info_changed, with the latter getting a link ID. > > Also change the 'changed' parameter to u64 already, we > > know we need that. > > [snip] > > > - wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss info changed vif %p changed 0x%08x\n", > > - vif, changed); > > + wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss info changed vif %p changed 0x%llx\n", > > + vif, (unsigned long long)changed); > > just curious about the typecasting. > > https://www.kernel.org/doc/html/latest/core-api/printk-formats.html > indicates we should always be able to use %lld or %llx for u64 hence no > typecasting should be needed > Hm. I think you're probably right - I used powerpc 20 years ago and it had 'unsigned long' for u64, but I guess that changed a LONG time ago... Yep, commit fe333321e2a71 (Jan 2009). Sorry, old habits die hard. :( johannes
