Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > Sparse lists the following for rtw88: > > CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c > drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static? > > The warning arises because the external declaration for rtw8822b_hw_spec > occurs in rtw8822be.h, which is not included in rtw8822b.h. That line is > moved, and the now empty file rtw8822be.h is deleted. > > Symbol 'rtw8822b_hw_spec' can be made constant. > > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx> 4 patches applied to wireless-next.git, thanks. f429298d68fb wifi: rtw88: Fix sparse warning for rtw8822b_hw_spec f86fc57f8ae3 wifi: rtw88: Fix Sparse warning for rtw8822c_hw_spec e36db29cfdff wifi: rtw88: Fix Sparse warning for rtw8723d_hw_spec 89d8f53ff6e7 wifi: rtw88: Fix Sparse warning for rtw8821c_hw_spec -- https://patchwork.kernel.org/project/linux-wireless/patch/20220524153621.19027-2-Larry.Finger@xxxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches