> -----Original Message----- > From: Ondřej Jirman <megi@xxxxxx> > Sent: Thursday, May 26, 2022 7:01 AM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: tony0620emma@xxxxxxxxx; kvalo@xxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Bernie Huang > <phhuang@xxxxxxxxxxx> > Subject: Re: [PATCH 3/6] rtw88: Add update beacon flow for AP mode > > Hello Ping-Ke, > > please see bugreport below: > > > > > +static int rtw_ops_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, > > + bool set) > > +{ > > + struct rtw_dev *rtwdev = hw->priv; > > + > > + mutex_lock(&rtwdev->mutex); > > + rtw_fw_download_rsvd_page(rtwdev); > > + mutex_unlock(&rtwdev->mutex); > > set_tim is supposed to be atomic. See: > https://elixir.bootlin.com/linux/latest/source/include/net/mac80211.h#L3500 > Thanks for pointing out. We will fix it. Ping-Ke