On Mon, Oct 20, 2008 at 11:25 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2008-10-20 at 10:40 -0700, colin@xxxxxxxxxxx wrote: >> The two new commands are NL80211_CMD_GET_MESH_PARAMS and >> NL80211_CMD_SET_MESH_PARAMS. There is a new attribute enum, >> NL80211_ATTR_MESH_PARAMS, which enumerates the various mesh configuration >> parameters. >> >> Moved struct mesh_config from mac80211/ieee80211_i.h to net/cfg80211.h. >> nl80211_get_mesh_params and nl80211_set_mesh_params unpack the netlink messages >> and ask the driver to get or set the configuration. This is done via two new >> function stubs, get_mesh_params and set_mesh_params, in struct cfg80211_ops. > >> + /* Set the mask */ >> + mask = 0; >> + for (i = 0; i < NL80211_MESHCONF_ATTR_MAX; ++i) >> + if (tb[i+1]) >> + mask |= (1 << i); > > Can you move that into the macro so it's set whenever you parse any of > the values? I think you probably missed that in my earlier mail? Or was > there a reason not to? Sure. I wasn't sure how strong your preference was, earlier. >> + /* Fill in the params struct */ >> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshRetryTimeout, >> + NL80211_MESHCONF_RETRY_TIMEOUT, nla_get_u16); > > >> + .cmd = NL80211_CMD_GET_MESH_PARAMS, >> + .doit = nl80211_get_mesh_params, >> + .policy = nl80211_policy, >> + .flags = GENL_ADMIN_PERM, > > Does this really need admin permission for getting the values? Hmm, I guess not. Colin > > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
