> -----Original Message----- > From: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Sent: Tuesday, May 24, 2022 11:36 PM > To: Kalle Valo <kvalo@xxxxxxxxxx> > Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; Larry Finger > <Larry.Finger@xxxxxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Subject: [PATCH v3 0/4] rtw88: Fix some Sparse Warnings > > Sparse shows warnings for symbols that can be static. In these cases. > the wrong solution is suggested - again reinforcing the concept > that all tools may suggest the wrong answer, and must be checked. > > Constify all *_hw_spec variables > > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> This patchset looks good to me. Thanks! Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>