On Mon, 2022-05-23 at 12:59 -0700, Jakub Kicinski wrote: > Hi folks, > > looks like I'm hitting this on a mips64 build: > > drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1093: warning: "CAUSE" redefined > 1093 | #define CAUSE(reg, mask) \ > | > In file included from ../arch/mips/include/asm/ptrace.h:19, > from ../include/linux/sched/signal.h:14, > from ../include/linux/rcuwait.h:6, > from ../include/linux/percpu-rwsem.h:7, > from ../include/linux/fs.h:33, > from ../arch/mips/include/asm/elf.h:12, > from ../include/linux/elf.h:6, > from ../include/linux/module.h:19, > from ../include/linux/device/driver.h:21, > from ../include/linux/device.h:32, > from ../include/linux/pci.h:37, > from ../drivers/net/wireless/intel/iwlwifi/pcie/trans.c:7: > arch/mips/include/uapi/asm/ptrace.h:18: note: this is the location of the previous definition > 18 | #define CAUSE 65 > | > > Throw an IWL_ before it, maybe? > Oh, right, I think that came up before and I dropped the ball on it, sorry. I'll add something. johannes