cppcheck reports [drivers/net/wireless/ath/ath9k/dfs.c:93]: (style) Assignment of function parameter has no effect outside the function. Both the is_ctl and the is_ext parameters are set in the if-else statement. But only is_ctl is used later, so setting is_ext is not needed and can be removed. Signed-off-by: Tom Rix <trix@xxxxxxxxxx> --- drivers/net/wireless/ath/ath9k/dfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/dfs.c b/drivers/net/wireless/ath/ath9k/dfs.c index acb9602aa464..47cdfb584eb0 100644 --- a/drivers/net/wireless/ath/ath9k/dfs.c +++ b/drivers/net/wireless/ath/ath9k/dfs.c @@ -89,8 +89,6 @@ static int ath9k_get_max_index_ht40(struct ath9k_dfs_fft_40 *fft, int mag_upper = fft_max_magnitude(fft->upper_bins); if (mag_upper > mag_lower) is_ctl = false; - else - is_ext = false; } } if (is_ctl) -- 2.27.0
