On Mon, 2008-10-20 at 08:47 +0200, Holger Schurig wrote: > > From: Ryan Mallon <ryan@xxxxxxxxxxxxxxxx> > > > > Change the return value of if_cs_poll_while_fw_download to > > zero on success, so that the firmware loading functions also > > correctly return zero on success. > > > > Signed-off-by: Ryan Mallon <ryan@xxxxxxxxxxxxxxxx> > > Acked-by: Dan Williams <dcbw@xxxxxxxxxx> > > The patch is ok, but the description is wrong. > > The function is supposed to return some error back, which is > negative, e.g. -ETIME. And callers test for (ret < 0) to find > out about the error condition. See here: Hmm, yeah, you're right. John, can drop this if you want. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
