On Fri, May 20, 2022 at 07:47:44AM +0000, Pkshih wrote: > On Wed, 2022-05-18 at 10:23 +0200, Sascha Hauer wrote: > > Add support for the rtw8723du chipset based on > > https://github.com/ulli-kroll/rtw88-usb.git > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > --- > > drivers/net/wireless/realtek/rtw88/Kconfig | 11 +++++ > > drivers/net/wireless/realtek/rtw88/Makefile | 3 ++ > > drivers/net/wireless/realtek/rtw88/rtw8723d.c | 19 +++++++++ > > drivers/net/wireless/realtek/rtw88/rtw8723d.h | 1 + > > .../net/wireless/realtek/rtw88/rtw8723du.c | 40 +++++++++++++++++++ > > .../net/wireless/realtek/rtw88/rtw8723du.h | 13 ++++++ > > 6 files changed, 87 insertions(+) > > create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723du.c > > create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723du.h > > > > > > [...] > > > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723du.c > > b/drivers/net/wireless/realtek/rtw88/rtw8723du.c > > new file mode 100644 > > index 0000000000000..910f64c168131 > > --- /dev/null > > +++ b/drivers/net/wireless/realtek/rtw88/rtw8723du.c > > @@ -0,0 +1,40 @@ > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause > > +/* Copyright(c) 2018-2019 Realtek Corporation > > + */ > > + > > +#include <linux/module.h> > > +#include <linux/usb.h> > > +#include "main.h" > > +#include "rtw8723du.h" > > +#include "usb.h" > > + > > +static const struct usb_device_id rtw_8723du_id_table[] = { > > + /* > > + * ULLI : > > + * ID found in rtw8822bu sources > > + */ > > checkpatch.pl will tell us this comment block should be > > /* ULLI : > * ID found in rtw8822bu sources > */ > > But, I think we can just "/* ULLI: ID found in rtw8822bu sources */" > if we really want to keep this comment. I'll drop this comment. > > + > > +#ifndef __RTW_8723DU_H_ > > +#define __RTW_8723DU_H_ > > + > > +/* USB Vendor/Product IDs */ > > +#define RTW_USB_VENDOR_ID_REALTEK 0x0BDA > > rtw8821cu.h and rtw8822bu.h define this too. > Can we move it to usb.h? Yes. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
