On Wed, 2022-05-18 at 10:23 +0200, Sascha Hauer wrote: > Add support for the rtw8822cu chipset based on > https://github.com/ulli-kroll/rtw88-usb.git > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > --- > drivers/net/wireless/realtek/rtw88/Kconfig | 11 +++++ > drivers/net/wireless/realtek/rtw88/Makefile | 3 ++ > drivers/net/wireless/realtek/rtw88/rtw8822c.c | 24 +++++++++++ > .../net/wireless/realtek/rtw88/rtw8822cu.c | 40 +++++++++++++++++++ > .../net/wireless/realtek/rtw88/rtw8822cu.h | 15 +++++++ > 5 files changed, 93 insertions(+) > create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8822cu.c > create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8822cu.h > > [...] > +MODULE_AUTHOR("Realtek Corporation"); Out of curiosity, there are many authors in your patchset. Do you collect these driver from various places? rtw8723du.c:MODULE_AUTHOR("Hans Ulli Kroll <linux@xxxxxxxxxxxxx>"); rtw8821cu.c:MODULE_AUTHOR("Hans Ulli Kroll <linux@xxxxxxxxxxxxx>"); rtw8822bu.c:MODULE_AUTHOR("Realtek Corporation"); rtw8822cu.c:MODULE_AUTHOR("Realtek Corporation"); usb.c:MODULE_AUTHOR("Realtek Corporation"); > +MODULE_DESCRIPTION("Realtek 802.11ac wireless 8822cu driver"); > +MODULE_LICENSE("Dual BSD/GPL"); > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822cu.h > b/drivers/net/wireless/realtek/rtw88/rtw8822cu.h > new file mode 100644 > index 0000000000000..16afe22a8216c > --- /dev/null > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822cu.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ > +/* Copyright(c) 2018-2019 Realtek Corporation > + */ > + > +#ifndef __RTW_8822CU_H_ > +#define __RTW_8822CU_H_ > + > +/* USB Vendor/Product IDs */ > +#define RTW_USB_VENDOR_ID_REALTEK 0x0BDA Like others, move this to usb.h > +#define RTW_USB_PRODUCT_ID_REALTEK_8812C 0xC812 > +#define RTW_USB_PRODUCT_ID_REALTEK_8822C 0xC82C > + > +extern struct rtw_chip_info rtw8822c_hw_spec; > + > +#endif -- Ping-Ke