On Fri, May 20, 2022 at 06:06:05AM +0000, Pkshih wrote:
> On Wed, 2022-05-18 at 10:23 +0200, Sascha Hauer wrote:
> > The driver uses ieee80211_iterate_active_interfaces_atomic()
> > and ieee80211_iterate_stations_atomic() in several places and does
> > register accesses in the iterators. This doesn't cope with upcoming
> ^^^^^^^ does?
> > USB support as registers can only be accessed non-atomically.
> >
> > Split these into a two stage process: First use the atomic iterator
> > functions to collect all active interfaces or stations on a list, then
> > iterate over the list non-atomically and call the iterator on each
> > entry.
>
> I think the subject could be "iterate over vif/sta list non-atomically"
Ok.
> > +void rtw_iterate_stas(struct rtw_dev *rtwdev,
> > + void (*iterator)(void *data,
> > + struct ieee80211_sta *sta),
> > + void *data)
> > +{
> > + struct rtw_iter_stas_data iter_data;
> > + struct rtw_stas_entry *sta_entry, *tmp;
>
> lockdep_assert_held(&rtwdev->mutex);
>
> > +
> > + iter_data.rtwdev = rtwdev;
> > + INIT_LIST_HEAD(&iter_data.list);
> > +
> > + ieee80211_iterate_stations_atomic(rtwdev->hw, rtw_collect_sta_iter,
> > + &iter_data);
> > +
> > + list_for_each_entry_safe(sta_entry, tmp, &iter_data.list,
> > + list) {
> > + list_del_init(&sta_entry->list);
> > + iterator(data, sta_entry->sta);
> > + kfree(sta_entry);
> > + }
> > +}
> > +
>
> [...]
>
> > +void rtw_iterate_vifs(struct rtw_dev *rtwdev,
> > + void (*iterator)(void *data, u8 *mac,
> > + struct ieee80211_vif *vif),
> > + void *data)
> > +{
> > + struct rtw_iter_vifs_data iter_data;
> > + struct rtw_vifs_entry *vif_entry, *tmp;
>
> lockdep_assert_held(&rtwdev->mutex);
Ok, will add these. For what it's worth they didn't trigger in a short
test.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
