Yongzhi Liu <lyz_cs@xxxxxxxxxx> writes: > If 'card' is not valid, then we need to check the > field 'adapter' and 'priv_num' to avoid use of NULL > pointer in function 'mwifiex_get_priv'. Fix this by > adding the null pointer check on them. Why? We don't add null checks for every access, why does this function need it? How did you find this? Is this something you found with a static checker tool or by testing with a real device? > Fixes: 21c5c83ce ("mwifiex: support sysfs initiated device coredump") Format is wrong, it should be: Fixes: 21c5c83ce833 ("mwifiex: support sysfs initiated device coredump") -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches