On Wed, 2022-05-18 at 11:18 -0700, Jakub Kicinski wrote: > Most protocol-specific pointers in struct net_device are under > a respective ifdef. Wireless is the notable exception. Since > there's a sizable number of custom-built kernels for datacenter > workloads which don't build wireless it seems reasonable to > ifdefy those pointers as well. > > While at it move IPv4 and IPv6 pointers up, those are special > for obvious reasons. > Not sure if the "ifdefy" in the subject is intentional, reads a bit odd to me :) but anyway looks good Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> Do you want me to follow up with trying to union the pointer into ml_priv? I prefer to union it rather than use ml_priv because we'll not want to use the getter everywhere when we already know, only on the boundaries. johannes