On 5/17/2022 3:50 AM, Johannes Berg wrote:
On Tue, 2022-05-17 at 07:45 +0300, Kalle Valo wrote:
+++ b/include/net/cfg80211.h
@@ -4200,7 +4200,7 @@ struct cfg80211_ops {
int (*start_ap)(struct wiphy *wiphy, struct net_device *dev,
struct cfg80211_ap_settings *settings);
int (*change_beacon)(struct wiphy *wiphy, struct net_device *dev,
- struct cfg80211_beacon_data *info);
+ struct cfg80211_ap_settings *info);
Shouldn't patch 3 folded into patch 1? I don't see how patch 1 as is
would compile without warnings.
Yes, and parts of patch 2 as well.
johannes
Little confused now between above comments and the following one:
https://patchwork.kernel.org/project/linux-wireless/patch/20220509225237.15955-1-quic_alokad@xxxxxxxxxxx/
Even if all driver changes from patch #3 are put with patch #1, it still
won't compile successfully without patch #2. Hence I had added all files
in a single patch for v4.
I'm now thinking that what you meant is split the actual FILS discovery
processing in a separate patch but keep the API changes (cfg80211,
mac80211 and drivers) in the first patch file.
Will do that in the next version.
Thanks
