Search Linux Wireless

Re: [PATCH v4] cfg80211: additional processing in NL80211_CMD_SET_BEACON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2022-05-09 at 15:52 -0700, Aloka Dixit wrote:
> FILS discovery and unsolicited broadcast probe response transmissions
> are configured as part of NL80211_CMD_START_AP, however both stop
> after userspace uses the NL80211_CMD_SET_BEACON command as these
> attributes are not processed as part of this command.
> 
> - Add the missing implementation in nl80211 and mac80211.
> - Modify the local variable in nl80211_set_beacon() and input parameter
> to rdev_change_beacon() from type struct cfg80211_beacon_data to
> type struct cfg80211_ap_settings to support the new processing.
> - Modify ieee80211_change_beacon() to reflect the new input parameter type.
> - Modify driver specific functions pointed by change_beacon to
> reflect the new input parameter type.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Aloka Dixit <quic_alokad@xxxxxxxxxxx>
> ---
> v4:
> - Modifications to all driver specific function pointers.

That's fine.

> - Also included all files in a single patch instead of splitting as per
> the modules because otherwise compilation fails with changes in only
> net/wireless and include/net directories.
> 

That I prefer not. Please send the mac80211 (and/or driver) changes
separately (make sure you edit the commit logs appropriately), with the
first cfg80211 change only containing the API updates across the rest of
the tree.

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux