Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > These tables are used by RFK (RF calibration) to set parameters. These > parameters can trigger certain calibration, or configure/reset settings > before and after RF calibrations. > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> 16 patches is too much, I only reviewed patches 1-8. Please split this patchset into two. 16 patches set to Changes Requested. 12831552 [v2,01/16] rtw89: 8852c: rfk: add RFK tables 12831545 [v2,02/16] rtw89: 8852c: rfk: add DACK 12831547 [v2,03/16] rtw89: 8852c: rfk: add LCK 12831551 [v2,04/16] rtw89: 8852c: rfk: add TSSI 12831546 [v2,05/16] rtw89: 8852c: rfk: add RCK 12831548 [v2,06/16] rtw89: 8852c: rfk: add RX DCK 12831556 [v2,07/16] rtw89: 8852c: rfk: add IQK 12831560 [v2,08/16] rtw89: 8852c: rfk: add DPK 12831549 [v2,09/16] rtw89: 8852c: rfk: get calibrated channels to notify firmware 12831550 [v2,10/16] rtw89: 8852c: add chip_ops::bb_ctrl_btc_preagc 12831555 [v2,11/16] rtw89: 8852c: add basic and remaining chip_info 12831553 [v2,12/16] rtw89: ps: fine tune polling interval while changing low power mode 12831554 [v2,13/16] rtw89: correct AID settings of beamformee 12831557 [v2,14/16] rtw89: 8852c: correct register definitions used by 8852c 12831559 [v2,15/16] rtw89: 8852c: fix warning of FIELD_PREP() mask type 12831558 [v2,16/16] rtw89: 8852c: add 8852ce to Makefile and Kconfig -- https://patchwork.kernel.org/project/linux-wireless/patch/20220429071809.32104-2-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches