On Wed, Apr 27, 2022 at 3:35 PM Loic Poulain <loic.poulain@xxxxxxxxxx> wrote: > On Tue, 26 Apr 2022 at 02:19, Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx> wrote: >> On Fri, Apr 8, 2022 at 1:37 AM Ricardo Martinez >> <ricardo.martinez@xxxxxxxxxxxxxxx> wrote: >>> ... >>> Co-developed-by: Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx> >>> Signed-off-by: Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx> >>> >>> From a WWAN framework perspective: >>> Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxx> >>> >>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> >> >> This line with "From a WWAN framework perspective" looks confusing to >> me. Anyone not familiar with all of the iterations will be in doubt as >> to whether it belongs only to Loic's review or to both of them. >> >> How about to format this block like this: >> >>> Co-developed-by: Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx> >>> Signed-off-by: Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx> >>> Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxx> (WWAN framework) >>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> >> >> or like this: >> >>> Co-developed-by: Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx> >>> Signed-off-by: Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx> >>> Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxx> # WWAN framework >>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> >> >> Parentheses vs. comment sign. I saw people use both of these formats, >> I just do not know which is better. What do you think? > > My initial comment was to highlight that someone else should double > check the network code, but it wasn't expected to end up in the commit > message. Maybe simply drop this extra comment? Yep, this drastically solves the problem with comment format :) I do not mind. -- Sergey
