Re: [RFC PATCH] cfg80211: do some rework towards MLO link APIs

[Vasanthakumar Thiagarajan <quic_vthiagar@xxxxxxxxxxx>]

On 4/26/2022 12:46 PM, Johannes Berg wrote:
> >   > +	if (internal_flags & NL80211_FLAG_MLO_VALID_LINK_ID) {
> >   > +		struct nlattr *link_id = info->attrs[NL80211_ATTR_MLO_LINK_ID];
>
> [...]
> >   > +		/* non-MLO -> no link ID attribute accepted */
> >   > +		if (!wdev->valid_links && link_id) {
> >
> > Isn't that we hit this condition when adding the very first link to the
> > MLD using NL80211_CMD_ADD_LINK?
>
> Oh, I don't think CMD_ADD_LINK would set NL80211_FLAG_MLO_VALID_LINK_ID,
> that's just helper functionality for those commands that expect
> everything to already be set up.

got it, thanks!

Vasanth