Search Linux Wireless

Re: [PATCH 2/3 v2] p54: put broadcast frames into the right queues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 18 October 2008 14:21:51 Johannes Berg wrote:
> On Fri, 2008-10-17 at 03:54 +0200, Christian Lamparter wrote:
> 
> > +	case NL80211_IFTYPE_AP:
> > +		if (is_multicast_ether_addr(hdr->addr1)) {
> > +			*aid = 0;
> > +			*queue = 3;
> > +			return 0;
> > +		}
> 
> Are you sure this is right? I think you should use the mac80211 flag
> IEEE80211_TX_CTL_SEND_AFTER_DTIM maybe?

Ack will post updated patches.

> Also, there's a flag for IEEE80211_TX_CTL_ASSIGN_SEQ (inverted in
> firmware) that you should use.
?

[PATCH 1/3] p54: more definitions form lmac_longbow.h and pda.h
adds in p54_tx(xyz): 
+       if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ)
+               hdr_flags |= P54_HDR_FLAG_DATA_OUT_SEQNR;
+
+       /* TODO: enable bursting */
+       hdr->flags = cpu_to_le16(hdr_flags);

Regards,
	Chr
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux