On Mon, Apr 25, 2022 at 04:11:44PM -0700, Brian Norris wrote: > On Mon, Apr 25, 2022 at 02:15:20AM +0000, Abhishek Kumar wrote: > > --- a/drivers/net/wireless/ath/ath10k/mac.c > > +++ b/drivers/net/wireless/ath/ath10k/mac.c > > @@ -5345,8 +5345,22 @@ static void ath10k_stop(struct ieee80211_hw *hw) ... > > + /* If the current driver state is RESTARTING but not yet > > + * fully RESTARTED because of incoming suspend event, > > + * then ath11k_halt is already called via > > s/ath11k/ath10k/ > > I know ath11k is the hot new thing, but this is ath10k ;) > > > + * ath10k_core_restart and should not be called here. > > s/ath10k/ath11k/ Oh boy, I got *that* backwards! Should be this, obviously: s/ath11k/ath10k/ > > + */ > > + if (ar->state != ATH10K_STATE_RESTARTING) > > + ath10k_halt(ar); > > + else > > + /* Suspending here, because when in RESTARTING > > + * state, ath11k_core_stop skips > > s/ath10k/ath11k/ Same. Brian
