Search Linux Wireless

Re: [PATCH v4 2/2] ath11k: Add support for SAR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/20/2022 9:35 AM, Kalle Valo wrote:
Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes:

On 4/1/2022 5:09 AM, Baochen Qiang wrote:
ath11k assigns ath11k_mac_op_set_bios_sar_specs to ath11k_ops,
and this function is called when user space application
calls NL80211_CMD_SET_SAR_SPECS. ath11k also registers SAR
type and frequency ranges to wiphy so user space can query
SAR capabilities.

I find this commit text very confusing since it uses "present simple"
tense instead of "imperative" tense so it comes across as describing
what the driver did prior to the patch instead of what the driver is
supposed to do after the patch is applied.

The patch itself LGTM.

I tried to improve the commit log, please check:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6b0778eaea60533a8b48df2d890543a48b590f55


LGTM!



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux