Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 4/1/2022 5:09 AM, Baochen Qiang wrote: >> From: Wen Gong <quic_wgong@xxxxxxxxxxx> >> >> Currently the wmi service bis is report from firmware, it is divided > > "bis" is a typo? > Also use of "Currently" here is confusing since it seems you are > changing that behavior. But the firmware reporting isn't changing, > only the host processing is changing. > > So perhaps: > When the WMI service bits are reported from firmware they are divided > into multiple segments, with 128 bits in each segment. > >> to 128 bits for each segment. The first segment is processed by >> ath11k_wmi_service_bitmap_copy(), the second segment is processed by >> ath11k_service_available_event() with WMI_TAG_SERVICE_AVAILABLE_EVENT, >> When the service bit exceed 256 bits, then firmware report it by tag >> WMI_TAG_ARRAY_UINT32 in WMI_SERVICE_AVAILABLE_EVENTID. >> >> ath11k does not process the third segment, this is to extend the wmi > > Here is where you can use "currently". And this is also a good place > to say why the change is needed since that is also missing from the > commit text. So consider: > Currently ath11k does not process the third segment. Upcoming features > need to know if firmware support is available for the features, so add > processing of the third segment. > > Also IMO the implementation details below do not need to be in the > commit text. > > I suspect Kalle can just apply these comments to his pending branch. Did that now, please check: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=d98a4c9bd0b32824ad9ee2d24ecabb345edfaafe -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
