On Fri, 2022-04-15 at 10:26 +0200, Felix Fietkau wrote: > On 15.04.22 08:14, Shayne Chen wrote: > > Add RF registers read/write support for debugging RF issues, which > > should be processed by mcu commands. > > > > Reviewed-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx> > > Signed-off-by: Peter Chiu <chui-hao.chiu@xxxxxxxxxxxx> > > Signed-off-by: Shayne Chen <shayne.chen@xxxxxxxxxxxx> > > What's the required width of rf_sel and rf_ofs? Would both fit > together > in a single u32? If so, you could just use the generic regidx > debugfs > file for both and simply add a rf_regval debugfs file. > > - Felix Hi Felix, FW use the WF sel (antenna 0-3) and offset to locate rf registers. I'll send an update patch to merge them in the generic regidx with wf sel [31:28] and offset [27:0]. Thanks, Shayne
