Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > The smatch reports: > rtw8852a.c:1857 rtw8852a_btc_set_wl_txpwr_ctrl() error: uninitialized symbol '_cur'. > rtw8852a.c:1858 rtw8852a_btc_set_wl_txpwr_ctrl() error: uninitialized symbol '_cur'. > > This is because rtw89_mac_txpwr_read32() can possibly return before setting > argument _cur, and the caller will use the uninitialized value. To fix this > problem, check the return value of rtw89_mac_txpwr_read32(). > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. 26bb93407c74 rtw89: handle potential uninitialized variable -- https://patchwork.kernel.org/project/linux-wireless/patch/20220318035202.42437-1-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches