Hi Kalle, On Mon, Apr 4, 2022 at 8:39 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes: > >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: > >> error: case label does not reduce to an integer constant: => 3798:2, > >> 3809:2 > > > > arm64-gcc5.4/arm64-allmodconfig > > powerpc-gcc5/powerpc-allmodconfig > > powerpc-gcc5/ppc64_book3e_allmodconfig > > After v5.17 there were two commits to brcmfmac/sdio.c: > > $ git log --oneline v5.17.. drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > ed26edf7bfd9 brcmfmac: Add BCM43454/6 support > 6d766d8cb505 brcmfmac: pcie: Declare missing firmware files in pcie.c > > I can't see how either of them could cause this warning. Could something > else cause this or am I missing something? Doh, I should not have reduced the CC list in the xfs subthread... The builds above are all gcc-5 builds, so they are affected by the same issue as XFS: unsigned constants that don't fit in int are lacking a "U" suffix. I assume Arnd's patch for drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c fixes this? https://lore.kernel.org/all/CAK8P3a0wRiS03imdXk2WbGONkSSczEGdE-ue5ubF6UyyDE9dQg@xxxxxxxxxxxxxx Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds