On Fri, Apr 01, 2022 at 01:31:38PM +0800, Meng Tang wrote: > Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR, > which makes the code a bit shorter and easier to read. Hi Meng Thanks for doing what i suggested. Looks good. Please take a look at https://docs.kernel.org/networking/netdev-FAQ.html There are a few process issues to work out, like the branch name in the subject, and that the merge window is currently closed so you will need to repost next week. Andrew