Hi Kalle, Sorry I missed to add the hw details, I tested on IPQ8074 hw2.0 AHB Thanks Karthikeyan -----Original Message----- From: Kalle Valo <kvalo@xxxxxxxxxx> Sent: Friday, April 1, 2022 5:25 PM To: Karthikeyan Kathirvel (QUIC) <quic_kathirve@xxxxxxxxxxx> Cc: ath11k@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx Subject: Re: [PATCH] ath11k: Change max no of active probe SSID and BSSID to fw capability WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. Karthikeyan Kathirvel <quic_kathirve@xxxxxxxxxxx> writes: > The maximum number of SSIDs in a for active probe requests is > currently reported as 16 (WLAN_SCAN_PARAMS_MAX_SSID) when registering the driver. > The scan_req_params structure only has the capacity to hold 10 SSIDs. > This leads to a buffer overflow which can be triggered from > wpa_supplicant in userspace. When copying the SSIDs into the > scan_req_params structure in the ath11k_mac_op_hw_scan route, it can > overwrite the extraie pointer. > > Firmware supports 16 ssid * 4 bssid, for each ssid 4 bssid combo probe > request will be sent, so totally 64 probe requests supported. So set > both max ssid and bssid to 16 and 4 respectively. Remove the redundant > macros of ssid and bssid. > > Tested-on : WLAN.HK.2.7.0.1-01300-QCAHKSWPL_SILICONZ-1 v1 This is not correct format: https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag On what hardware did you test this? I can then fix the tag. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
