> -----Original Message----- > From: Kalle Valo <kvalo@xxxxxxxxxx> > Sent: Monday, March 21, 2022 5:56 PM > To: Baochen Qiang (QUIC) <quic_bqiang@xxxxxxxxxxx> > Cc: ath11k@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] ath11k: Add support for SAR > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > "Baochen Qiang (QUIC)" <quic_bqiang@xxxxxxxxxxx> writes: > > >> -----Original Message----- > >> From: Kalle Valo <kvalo@xxxxxxxxxx> > >> Sent: Friday, March 18, 2022 11:51 PM > >> To: Baochen Qiang (QUIC) <quic_bqiang@xxxxxxxxxxx> > >> Cc: ath11k@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx > >> Subject: Re: [PATCH] ath11k: Add support for SAR > >> > >> Baochen Qiang <quic_bqiang@xxxxxxxxxxx> wrote: > >> > >> > ath11k assigns ath11k_mac_op_set_bios_sar_specs to ath11k_ops, and > >> > this function is called when user space application calls > >> > NL80211_CMD_SET_SAR_SPECS. ath11k also registers SAR type and > >> > frequency ranges to wiphy so user space can query SAR capabilities. > >> > > >> > This feature is currently enabled for WCN6855. > >> > > >> > Tested-on: WCN6855 hw2.0 PCI > >> > WLAN.HSP.1.1-02431-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > >> > > >> > Signed-off-by: Baochen Qiang <quic_bqiang@xxxxxxxxxxx> > >> > >> What did you use as the baseline? I could not able to find an ath- > >> tag to which this patch would apply. I strongly recommend using > >> --base, that way I don't need to waste time trying to guess what was the > baseline. > >> > >> Patch set to Changes Requested. > >> > > > > Hi Kalle, I have added the base flag in v2. > > Thanks. > > > And please note this patch depends on > > https://patchwork.kernel.org/project/linux-wireless/patch/202112240852 > > 36.9064-2-quic_wgong@xxxxxxxxxxx/ > > which is now in public review. > > If there are any dependencies, please document them clearly after the "---" line. > I don't have time to start guessing what dependencies there might be for your > patches, especially if the dependency is several months as in this case. > > But why are you using that patch as the baseline? It's marked as Changes > Requested and it's unclear then it can be merged. If you need that patch, you > should create a patchset with patch 1 being "ath11k: add support for extended > wmi service bit" and patch 2 being "ath11k: Add support for SAR". > Sure Kalle, I will send a new patch set including " ath11k: add support for extended wmi service bit " > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatch > es
