Kalle Valo <kvalo@xxxxxxxxxx> writes: > Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes: > >> On 30/03/22 23.44, Toke Høiland-Jørgensen wrote: >>> The ath9k driver was not properly clearing the status area in the >>> ieee80211_tx_info struct before reporting TX status to mac80211. Instead, >>> it was manually filling in fields, which meant that fields introduced later >>> were left as-is. >>> >>> Conveniently, mac80211 actually provides a helper to zero out the status >>> area, so use that to make sure we zero everything. >>> >>> The last commit touching the driver function writing the status information >>> seems to have actually been fixing an issue that was also caused by the >>> area being uninitialised; but it only added clearing of a single field >>> instead of the whole struct. That is now redundant, though, so revert that >>> commit and use it as a convenient Fixes tag. >>> >>> Fixes: cc591d77aba1 ("ath9k: Make sure to zero status.tx_time before reporting TX status") >>> Reported-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx> >>> Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxx> >> >> No regressions and UBSAN warning [1] reported on dmesg. >> >> Tested-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx> >> >> However, there is something missing. I don't see Cc: stable@xxxxxxxxxxxxxxx >> trailer in this patch. I think it should, because I reported that this issue >> first occurred on v5.17, then still appeared on v5.17.1. > > I can add that during commit. Thanks! And sorry about that, I have gotten so used to the netdev policy of not including an explicit stable Cc that I totally forgot that this doesn't apply to the wireless tree. In any case I think the stable tree autoselection bit should pick it up from the Fixes tag, though... -Toke