On 03/25/2022, Jakub Kicinski wrote: > On Fri, 25 Mar 2022 23:57:33 +0000 William McVicker wrote: > > Instead of open coding it, we could just pass the internal_flags via struct > > genl_info to nl80211_vendor_cmds() and then handle the rtnl_unlock() there if > > the vendor command doesn't request it. I included the patch below in case > > there's any chance you would consider this for upstream. This would at least > > add backwards compatibility to the vendor ops API so that existing drivers that > > depend on the RTNL being held don't need to be fully refactored. > > Sorry to step in, Johannes may be AFK already. There's no asterisk next > to the "we don't cater to out of tree code" rule, AFAIK. We change > locking often, making a precedent like this would be ill-advised. Yeah I understand. I'll talk to Broadcom about this to see why they didn't use the existing upstream NAN interface. This sounds like it's going to be a problem for all the Android out-of-tree drivers. Thanks for the help! --Will
