On Friday, 25 March 2022 06:59:47 CET Maharaja Kennadyrajan wrote:
> @@ -5555,6 +5558,10 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
> params->dtim_period =
> nla_get_u32(info->attrs[NL80211_ATTR_DTIM_PERIOD]);
>
> + if (info->attrs[NL80211_ATTR_BEACON_TX_MODE])
> + params->beacon_tx_mode =
> + nla_get_u32(info->attrs[NL80211_ATTR_BEACON_TX_MODE]);
> +
> err = cfg80211_validate_beacon_int(rdev, dev->ieee80211_ptr->iftype,
> params->beacon_interval);
> if (err)
But why are you setting it by vif when it is actually a PHY setting? [1]
And there is also the open question from Felix [2]:
On Tuesday, 10 August 2021 16:33:41 CET Felix Fietkau wrote:
> It still seems to me like something that the driver should detect and
> handle internally without user configuration, based on number of VAPs
> and maybe multicast/beacon rate (since the packet duration issue will be
> worse with CCK rates).
Kind regards,
Sven
[1] https://lore.kernel.org/all/2718995.X0rUDs3ZmB@ripper/
https://lore.kernel.org/all/4581459.tLtf2NohVe@ripper/
https://lore.kernel.org/all/6210385.n8AMQ0p90U@ripper/
https://lore.kernel.org/all/4594028.WNQrFERZ9z@ripper/
[2] https://lore.kernel.org/all/92b48724-277c-fc48-a922-6b1d49cd6a71@xxxxxxxx/Attachment:
signature.asc
Description: This is a digitally signed message part.
