Search Linux Wireless

Re: [PATCH V2] wireless: broadcom: b43legacy: Fix assigning negative value to unsigned variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/24/22 03:06, Haowen Bai wrote:
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43legacy/phy.c:1181 b43legacy_phy_lo_b_measure()
warn: assigning (-772) to unsigned variable 'fval'

Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>

This change makes no change to the executable code, but as long as it makes smatch happy -

Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

Larry

---
V1->V2: modify title of this patch
  drivers/net/wireless/broadcom/b43legacy/phy.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/phy.c b/drivers/net/wireless/broadcom/b43legacy/phy.c
index 05404fb..c1395e6 100644
--- a/drivers/net/wireless/broadcom/b43legacy/phy.c
+++ b/drivers/net/wireless/broadcom/b43legacy/phy.c
@@ -1123,7 +1123,7 @@ void b43legacy_phy_lo_b_measure(struct b43legacy_wldev *dev)
  	struct b43legacy_phy *phy = &dev->phy;
  	u16 regstack[12] = { 0 };
  	u16 mls;
-	u16 fval;
+	s16 fval;
  	int i;
  	int j;




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux